RFR: 8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java [v2]

Weijun Wang weijun at openjdk.org
Thu May 1 15:28:47 UTC 2025


On Thu, 1 May 2025 10:31:20 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changed file creation to use Utils.createTempFile

LGTM. Or, you can just create files named `algName-keySize.ks`. There is no need to be random here.

-------------

Marked as reviewed by weijun (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24718#pullrequestreview-2810033523


More information about the security-dev mailing list