RFR: 8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java [v2]

Mikhail Yankelevich myankelevich at openjdk.org
Thu May 1 18:08:42 UTC 2025


On Thu, 1 May 2025 15:34:11 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed file creation to use Utils.createTempFile
>
> test/jdk/sun/security/pkcs12/P12SecretKey.java line 88:
> 
>> 86:                                    " keystore");
>> 87:             } else {
>> 88:                 System.err.println("ERROR: keys are NOT equal after storing in "
> 
> Test should fail here, throw RuntimeException.

Done in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24718#discussion_r2070594467


More information about the security-dev mailing list