Integrated: 8348732: SunJCE and SunPKCS11 have different PBE key encodings

[Valerie Peng]

On Fri, 14 Mar 2025 21:58:47 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), SunPKCS11 provider added support for PBE SecretKeyFactories for `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys whose encoding contains the PBKDF2 derived bytes. Given that SunJCE provider have supported `PBEWithHmacSHAxxxAndAES_yyy` SecretKeyFactories whose key encoding is the password bytes for long time. Such difference may be very confusing, e.g. using the same KeySpec and same-name SecretKeyFactory (from different providers), the resulting keys have same algorithm and format but different encodings.
> 
> Given that the `P11Mac` and `P11PBECipher` classes already do key derivation internally, these PKCS11 SecretKeyFactories aren't a must-have and are proposed to be removed. I've also aligned the com.sun.crypto.provider.PBEKey class with com.sun.crypto.provider.PPBKDF2KeyImpl class to switch to "UTF-8" when converting the char[] to byte[]. This is to accomodate unicode passwords and given that "UTF-8" encoding is same for ASCII characters, this change should not affect backward compatibility.

This pull request has now been integrated.

Changeset: 6536430a
Author:    Valerie Peng <valeriep at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6536430a3bdedcf5e0636e0eb27bde5e0d7b40fd
Stats:     472 lines in 12 files changed: 38 ins; 240 del; 194 mod

8348732: SunJCE and SunPKCS11 have different PBE key encodings

Reviewed-by: weijun, fferrari

-------------

PR: https://git.openjdk.org/jdk/pull/24068