RFR: 8298420: PEM API: Implementation (Preview) [v14]

Weijun Wang weijun at openjdk.org
Tue May 6 21:29:30 UTC 2025


On Thu, 24 Apr 2025 20:12:50 GMT, Mark Reinhold <mr at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - javadoc updates
>>  - code review comments
>
> src/java.base/share/classes/java/security/PEMEncoder.java line 74:
> 
>> 72:  *
>> 73:  * <p>{@code String} values returned by this class use character set
>> 74:  * {@link java.nio.charset.StandardCharsets#ISO_8859_1 ISO-8859-1}.
> 
> As above, did you mean to write something like, "Byte arrays returned by methods in this class represent characters encoded using the ISO-8859-1 charset" ?

Yes, only `byte[]` has an encoding. BTW, please be specific this is about the `encode` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2076276493


More information about the security-dev mailing list