RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

Chen Liang liach at openjdk.org
Thu May 8 14:55:07 UTC 2025


On Wed, 7 May 2025 18:33:11 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Document preconditions on certain `JavaLangAccess` methods that use operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Prefix touched methods with `unchecked`

Reviewed missing copyright updates. Only files with comments need copyright year updates.

Let's re-approve after copyright fix.

src/java.base/share/classes/java/io/DataInputStream.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/java/io/ObjectInputStream.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/java/util/HexFormat.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/java/util/zip/ZipCoder.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/jdk/internal/util/HexDigits.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/sun/nio/cs/CESU_8.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/sun/nio/cs/DoubleByte.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/sun/nio/cs/ISO_8859_1.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/sun/nio/cs/SingleByte.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/sun/nio/cs/US_ASCII.java line 1:

> 1: /*

Copyright year

src/java.base/share/classes/sun/nio/cs/UTF_8.java line 1:

> 1: /*

Copyright year

src/java.base/unix/classes/sun/nio/fs/UnixPath.java line 1:

> 1: /*

Copyright year

src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP.java.template line 1:

> 1: /*

Copyright year

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24982#pullrequestreview-2825397502
Changes requested by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24982#pullrequestreview-2825413999
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079869063
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079869753
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079870851
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079871207
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079873366
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079874098
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079874388
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079874760
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079875143
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079875444
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079875789
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079876056
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079876669
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2079877098


More information about the security-dev mailing list