RFR: 8298420: PEM API: Implementation (Preview) [v15]

[Anthony Scarpino]

On Wed, 7 May 2025 19:02:47 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> src/java.base/share/classes/java/security/PEMDecoder.java line 118:
>> 
>>> 116:     /**
>>> 117:      * Returns an instance of {@code PEMDecoder}.  This instance may be repeatedly used
>>> 118:      * to decode different PEM text.
>> 
>> Not only repeatable, but also thread safe I assume? Maybe we need to talk about this in the class spec. Immutable does not automatic implies thread-safe, if the immutability is only observed on the API level.
>
> Usually there is a sentence at the end of the class description, ex- "This class is immutable and thread-safe." Once you state that, you don't need to say anything more in the methods like the sentence above about repeatability.

I added a line in the class doc and removed the line about repeatedly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2078866665