RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v8]

Kevin Driver kdriver at openjdk.org
Mon May 12 19:35:54 UTC 2025


On Thu, 8 May 2025 21:19:10 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API for the HKDF support from JCA/JCE providers.
>> 
>> This is just code refactoring. Known-answer regression test for the internal JSSE HKDF impl is removed as the test vectors are already covered by the HKDF impl in SunJCE provider.
>> 
>> Thanks in advance for the review~
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review feedbacks from Brad.

src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java line 128:

> 126: 
> 127:             // derive handshake secret
> 128:             // NOTE: do not reuse the HKDF object for "TlsEarlySecret" for

Nit: There is no longer an "HKDF object". Might be worth updating this comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2085321919


More information about the security-dev mailing list