RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v8]

[Valerie Peng]

On Mon, 12 May 2025 19:38:59 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review feedbacks from Brad.
>
> src/java.base/share/classes/sun/security/ssl/SSLBasicKeyDerivation.java line 49:
> 
>> 47:         this.secret = secret;
>> 48:         this.hkdfInfo = createHkdfInfo(label, context, hashAlg.hashLength);
>> 49:         this.keyLen = hashAlg.hashLength;
> 
> Very minor nit: might be worth accessing this field once and passing `this.keyLen` to `createHkdfInfo` instead.

Hmm, I like to match the ordering in the constructor with the ordering of fields. Since this is relatively minor, I am inclined to leave it as is...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2085627595