RFR: 8298420: PEM API: Implementation (Preview) [v16]

[Anthony Scarpino]

On Fri, 9 May 2025 15:13:18 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - comments
>>  - toString update
>>  - non-sealed
>>    Better X509 KeyPair parsing
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 62:
> 
>> 60:  * <p> If the PEM does not have a JCE object representation, it returns a
>> 61:  * {@link PEMRecord}. Any PEM can be decoded into a {@code PEMRecord} if the
>> 62:  * class is specified.
> 
> I would move the second sentence to later after you descibe the `decode` methods that take a `Class` param.

ok

> src/java.base/share/classes/java/security/PEMDecoder.java line 271:
> 
>> 269: 
>> 270:     /**
>> 271:      * Decodes and returns the specified class for the given PEM string.
> 
> Suggest slight rewording: "Decodes and returns a {@code DEREncodable} of the specified class from the given PEM string."

ok

> src/java.base/share/classes/java/security/PEMDecoder.java line 274:
> 
>> 272:      * {@code tClass} must extend {@link DEREncodable} and be an appropriate
>> 273:      * class for the PEM type.
>> 274:      *
> 
> Probably should say something about non-PEM data, ex: "For classes other than `PEMRecord`, non-PEM data before the PEM header is ignored."

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2085360976
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2085757494
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2085769233