RFR: 8298420: PEM API: Implementation (Preview) [v18]

[Sean Mullan]

On Tue, 13 May 2025 09:27:37 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments on the 11th

src/java.base/share/classes/java/security/DEREncodable.java line 37:

> 35: 
> 36: /**
> 37:  * This is a top-level interface for security classes that contain cryptographic

Wording suggestion (taken from JEP): "This interface is implemented by security API classes that contain binary-encodable key or certificate material."

src/java.base/share/classes/java/security/DEREncodable.java line 40:

> 38:  * data which may not be related or have a common class hierarchy.  These
> 39:  * security objects provide standard binary encoding, like ASN.1, and possible
> 40:  * type formats, like X.509 and PKCS#8.

Wording suggestion (taken from JEP): "These APIs or their subclasses typically provide methods to convert their instances to and from byte arrays in the [Distinguished Encoding Rules (DER)](https://en.wikipedia.org/wiki/X.690#DER_encoding) format."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2087297634
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2087321281