RFR: 8298420: PEM API: Implementation (Preview) [v20]

[Weijun Wang]

On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments

src/java.base/share/classes/java/security/PEMRecord.java line 83:

> 81:     public PEMRecord(String type, String pem, byte[] leadingData) {
> 82:         Objects.requireNonNull(type, "\"type\" cannot be null.");
> 83:         Objects.requireNonNull(type, "\"pem\" cannot be null.");

Typo, should check `pem`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2088725370