RFR: 8298420: PEM API: Implementation (Preview) [v20]

[Weijun Wang]

On Wed, 14 May 2025 11:36:46 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments
>
> src/java.base/share/classes/java/security/PEMRecord.java line 119:
> 
>> 117: 
>> 118:      * @param type the PEM type identifier
>> 119:      * @param pem the Base64-encoded data encapsulated by the PEM header and
> 
> Since internal `pem` is a string, you need to mention the charset of `pem` argument here. Does it make sense to choose another argument name? Like `pemBytes`.

Also, how useful is this method? I'd rather reserve the constructor to provide binary data (before Base64).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2088733615