RFR: 8298420: PEM API: Implementation (Preview) [v20]

[Sean Mullan]

On Wed, 14 May 2025 08:25:41 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments

A few remaining very minor comments. This is looking really good now.

src/java.base/share/classes/java/security/PEMDecoder.java line 271:

> 269:      * on the {@code InputStream} to decode additional PEM data.
> 270:      * The {@code InputStream} read pointer will remain at the end of
> 271:      * the PEM footer unless an IOException occurs.

Put code font around IOException.

src/java.base/share/classes/java/security/PEMEncoder.java line 129:

> 127: 
> 128:     /**
> 129:      * Returns a instance of {@code PEMEncoder}.

s/a/an/

src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 398:

> 396:      * used.
> 397:      *
> 398:      * @param key The {@code PrivateKey} to be encrypted

s/The/the/

src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 544:

> 542: 
> 543:     /**
> 544:      * Returns a {@code PrivateKey} from the encrypted data in this instance.

Remove '.'

-------------

PR Review: https://git.openjdk.org/jdk/pull/17543#pullrequestreview-2840745733
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089565932
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089272910
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089639029
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089633768