RFR: 8298420: PEM API: Implementation (Preview) [v20]

[Anthony Scarpino]

On Wed, 14 May 2025 15:52:34 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments
>
> src/java.base/share/classes/java/security/DEREncodable.java line 41:
> 
>> 39:  * These APIs or their subclasses typically provide methods to convert
>> 40:  * their instances to and from byte arrays in the Distinguished
>> 41:  * Encoding Rules (DER) format (ITU X.690).
> 
> You can probably leave out the reference to X.690 - DER is used in many of our APIs, and typically the DER format for that specific API will be specified by an RFC like 5280.

ok

> src/java.base/share/classes/java/security/PEMDecoder.java line 271:
> 
>> 269:      * on the {@code InputStream} to decode additional PEM data.
>> 270:      * The {@code InputStream} read pointer will remain at the end of
>> 271:      * the PEM footer unless an IOException occurs.
> 
> Put code font around IOException.

ok

> src/java.base/share/classes/java/security/PEMEncoder.java line 129:
> 
>> 127: 
>> 128:     /**
>> 129:      * Returns a instance of {@code PEMEncoder}.
> 
> s/a/an/

ok

> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 398:
> 
>> 396:      * used.
>> 397:      *
>> 398:      * @param key The {@code PrivateKey} to be encrypted
> 
> s/The/the/

ok

> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 544:
> 
>> 542: 
>> 543:     /**
>> 544:      * Returns a {@code PrivateKey} from the encrypted data in this instance.
> 
> Remove '.'

address by other change

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089691659
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089695970
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089698078
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089699784
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089702862