RFR: 8357033: Reduce stateless session ticket size [v2]

[Artur Barashev]

On Tue, 20 May 2025 09:05:28 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Log error and return null no compress/decompress failure
>
> src/java.base/share/classes/sun/security/ssl/SessionTicketExtension.java line 238:
> 
>> 236:                 byte compressed = 0;
>> 237:                 if (data.length >= MIN_COMPRESS_SIZE) {
>> 238:                     data = compress(data);
> 
> we should probably handle the null return here.

Good point, thanks! We should return `null` here if compression fails for some reason.

> src/java.base/share/classes/sun/security/ssl/SessionTicketExtension.java line 262:
> 
>> 260:         }
>> 261: 
>> 262:         ByteBuffer decrypt(HandshakeContext hc) throws IOException {
> 
> does it really throw?

Removed. It was left here after I moved decompression to a separate method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25310#discussion_r2098327581
PR Review Comment: https://git.openjdk.org/jdk/pull/25310#discussion_r2098331444