Integrated: 8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE

Anthony Scarpino ascarpino at openjdk.org
Fri May 30 20:15:58 UTC 2025


On Thu, 29 May 2025 22:38:41 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> I need a code review to throw `InvalidKeySpecException` when null is passed with `generatePublic()` and `generatePrivate()`.  This change takes the opportunity to modernize the KeyFactory code by using `switch` syntax for `instanceof` checking, as well as, keeping the previous design of the implementation method handling the null case.  There are existing JCK test cover this case, so no regression test is added.

This pull request has now been integrated.

Changeset: c9d6e012
Author:    Anthony Scarpino <ascarpino at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c9d6e01233fbc9f3a95a4879feff906748649c54
Stats:     200 lines in 4 files changed: 51 ins; 20 del; 129 mod

8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE

Reviewed-by: weijun

-------------

PR: https://git.openjdk.org/jdk/pull/25533


More information about the security-dev mailing list