RFR: 8370942: test/jdk/java/security/Provider/NewInstance.java and /test/jdk/java/security/cert/CertStore/NoLDAP.java may skip without notifying [v4]
Mikhail Yankelevich
myankelevich at openjdk.org
Tue Nov 4 08:37:48 UTC 2025
On Tue, 4 Nov 2025 02:07:51 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Neha Joshi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8370942 : Reveiw comment fixes.
>
> test/jdk/java/security/cert/CertStore/NoLDAP.java line 39:
>
>> 37: try {
>> 38: Class.forName("javax.naming.ldap.LdapName");
>> 39: System.out.println("LDAP is present, test skipped");
>
> Maybe we can add a new line to throw a Exception when the expected ClassNotFoundException do not seen.
>
>
> throw new RuntimeException("The expexted ClassNotFoundException was not observed.");
I'm not sure this would work tbh. This is an optional setting and failing the test due to the machine being setup for other tests may just introduce the noise from a false negative result.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28112#discussion_r2489244707
More information about the security-dev
mailing list