RFR: 8371383: Test sun/security/tools/jarsigner/DefaultOptions.java failed due to CertificateNotYetValidException [v2]

[Hai-May Chao]

On Fri, 7 Nov 2025 12:28:21 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update with Mikhail's comments
>
> test/jdk/sun/security/tools/jarsigner/DefaultOptions.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @bug 8049834 8371383
> 
> Minor: This is a test issue, could you please remove the bug id from here, as it only tracks product ones?

Removed the bug id.

> test/jdk/sun/security/tools/jarsigner/DefaultOptions.java line 79:
> 
>> 77:         // Add delay to help the signing certificate’s NotBefore time has
>> 78:         // passed and avoid CertificateNotYetValidException.
>> 79:         Thread.sleep(5000);
> 
> I wonder if it wouldn't be cleaner to add ` -startdate -1M ` to the cert gen instead of sleeping in the test. similar to [this pr](https://github.com/openjdk/jdk/pull/23001).
>  
> What do you think?

Updated code as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28186#discussion_r2504065098
PR Review Comment: https://git.openjdk.org/jdk/pull/28186#discussion_r2504068528