RFR: 8325448: Hybrid Public Key Encryption [v46]

[Weijun Wang]

On Wed, 5 Nov 2025 23:40:15 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 62 commits:
>> 
>>  - merge
>>  - Merge branch 'master' into 8325448
>>  - Tony's comment
>>  - more key checks; some small spec change
>>  - Merge branch 'master' into 8325448
>>  - about transformation
>>  - cannot reset with withMethods
>>  - algorithm identifier
>>  - withMethods
>>  - duplicated "value" words
>>  - ... and 52 more: https://git.openjdk.org/jdk/compare/cf45e09c...b5112151
>
> src/java.base/share/classes/com/sun/crypto/provider/HPKE.java line 318:
> 
>> 316:             }
>> 317: 
>> 318:             SecretKey ExportKey(String algorithm, byte[] exporter_context, int L) {
> 
> Why are the methods in this class capitalized?

I like using the original function names from the RFC. If you don't like, I can modify them to Java-style.

> src/java.base/share/classes/com/sun/crypto/provider/HPKE.java line 540:
> 
>> 538:                 // thw builder are just byte arrays. Any KDF impl can handle this.
>> 539:                 var kdf = KDF.getInstance(kdfAlg);
>> 540:                 var key_schedule_context = concat(new byte[]{(byte) mode},
> 
> Is `key_sechedule_context` worth zero'ing?

Maybe not? `psk_id` does not sound like a secret thing. I understand `psk` is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2505776074
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2505777566