RFR: 8371450: AES performance improvements for key schedule generation [v3]

[Shawn M Emery]

On Mon, 10 Nov 2025 21:13:10 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Shawn M Emery has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clean up comments - take two
>
> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 974:
> 
>> 972:      * Generate the inverse cipher round keys.
>> 973:      *
>> 974:      * @param w [in] the targeted word for substituion.
> 
> nit: substitution

Updated.

> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 975:
> 
>> 973:      *
>> 974:      * @param w [in] the targeted word for substituion.
>> 975:      * @param rounds [in] the number rounds for generating the round keys.
> 
> nit: missing "of"?

Updated.

> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 1011:
> 
>> 1009: 
>> 1010:     /**
>> 1011:      * Subtitute the word as a step of key expansion.
> 
> nit: Substitute

Updated.

> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 1013:
> 
>> 1011:      * Subtitute the word as a step of key expansion.
>> 1012:      *
>> 1013:      * @param word [in] the targeted word for substituion.
> 
> nit: substitution

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28188#discussion_r2512255650
PR Review Comment: https://git.openjdk.org/jdk/pull/28188#discussion_r2512257025
PR Review Comment: https://git.openjdk.org/jdk/pull/28188#discussion_r2512254700
PR Review Comment: https://git.openjdk.org/jdk/pull/28188#discussion_r2512255257