RFR: 8349546: Linux support for Kerberos "nativeccache" functionality [v11]

Nick Hall duke at openjdk.org
Wed Nov 12 15:15:25 UTC 2025


On Wed, 12 Nov 2025 14:28:55 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Nick Hall has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Attend to @smemery's code review comments
>
> src/java.security.jgss/share/classes/sun/security/krb5/Credentials.java line 536:
> 
>> 534:             System.loadLibrary("osxkrb5");
>> 535:         } else if (OperatingSystem.isLinux()) {
>> 536:             System.loadLibrary("linuxkrb5");
> 
> Can we use the same lib name on macOS and Linux?

We can - this was mostly just an attempt to avoid changing MacOS for the sake of a library name - I also wasn't sure if this might lead to other packaging changes/issues for people who package JVMs for MacOS?  My original approach had a single name, so it would straightforward to make this happen.  What do you think?

> test/jdk/sun/security/krb5/native/NativeCacheTest.java line 146:
> 
>> 144:         }
>> 145: 
>> 146:         // Fallback to the default cache if copying from file cache fails
> 
> Could this happen? Will there be unexpected ticket in the default cache?

I think this (and your other comment on the test helper) could be simplified, I'll do that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28075#discussion_r2518702065
PR Review Comment: https://git.openjdk.org/jdk/pull/28075#discussion_r2518703906


More information about the security-dev mailing list