RFR: 8371820: Further AES performance improvements for key schedule generation [v3]
Martin Doerr
mdoerr at openjdk.org
Mon Nov 17 15:12:46 UTC 2025
On Fri, 14 Nov 2025 07:28:10 GMT, Shawn M Emery <duke at openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More minor cleanup.
>
> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 61:
>
>> 59: // used for everything else.
>> 60: private int[] sessionKe = null; // key for encryption
>> 61: private int[] sessionKd = null; // preprocessed key for decryption
>
> We really don't need sessionKd, since it's just assigned to K, but I'm fine leaving it as is.
@smemery: I have made a proposal to remove `K`: https://github.com/TheRealMDoerr/jdk/commit/2907475958806cad6b5fc83541f66065475a93ec
Please take a look! I think it's a bit better readable, but makes the change a bit larger and will probably require a Graal update. What do you prefer?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28299#discussion_r2534468284
More information about the security-dev
mailing list