RFR: 8372004: Have SSLLogger implement System.Logger [v3]

[Sean Coffey]

On Tue, 18 Nov 2025 16:05:34 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments from Daniel
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 190:
> 
>> 188:     }
>> 189: 
>> 190:     private static void help() {
> 
> Keeping the help method at ~ the same place in the file would make it easier to review. Was there any change in this method?

yes - same code. Sorry, just thought it was better to move that method down the class. Not too interesting.

> test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 94:
> 
>> 92:                             + System.lineSeparator() +
>> 93:                             "  \"certificate\" : \\{",
>> 94:                         "sun.security.ssl.SSLSocketImpl close",
> 
> was that change intended? I don't see what it has to do with the rest.

yes - so with the System.Logger in use, we expect to see "sun.security.ssl.SSLSocketImpl close" now instead of the old "sun.security.ssl.SSLLogger log" calls. 

info in JBS report

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28376#discussion_r2538926633
PR Review Comment: https://git.openjdk.org/jdk/pull/28376#discussion_r2538930489