RFR: 8371820: Further AES performance improvements for key schedule generation [v3]
Valerie Peng
valeriep at openjdk.org
Tue Nov 18 21:48:16 UTC 2025
On Tue, 18 Nov 2025 21:38:00 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 62:
>>
>>> 60: private int[] sessionKe = null; // key for encryption
>>> 61: private int[] sessionKd = null; // preprocessed key for decryption
>>> 62: private int[] K = null; // preprocessed key in case of decryption
>>
>> I find the comment confusing as `K` is sometimes assigned with `sessionKe`, so it can't be used only for decryption?
>
> Thanks for looking at it! I've merged my additional proposal. `K` is removed, now. Does the Java part look ok? I'll ask for a hotspot review once the Java part is fine.
Java part looks fine to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28299#discussion_r2539716623
More information about the security-dev
mailing list