RFR: 8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes [v3]

Jiangli Zhou jiangli at openjdk.org
Thu Nov 20 05:06:58 UTC 2025


On Tue, 18 Nov 2025 08:33:32 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix Whitespace error.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 3530:
> 
>> 3528:   __ bind(MESG_BELOW_32_BLKS);
>> 3529:   __ subl(len, 16 * 16);
>> 3530:   __ cmpl(len, 256);
> 
> From the stylistic logic, this should be written as `16 * 16`, to match the surrounding `subl` and `addl`.

Thanks for the detailed review, @shipilev! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28363#discussion_r2544340100


More information about the security-dev mailing list