RFR: 8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags

[Matthew Donovan]

On Thu, 20 Nov 2025 13:05:44 GMT, Neha Joshi <duke at openjdk.org> wrote:

> In this PR we have updated the code to remove the duplicate call and ensure JVM flags are added only once.
> 
> ### ISSUE :- 
> In the test case --> ProcessTools.createTestJavaProcessBuilder(Utils.addTestJavaOpts("SSLEngineKeyLimit", "p", args[1], args[2]));
>     
> -> Before executing ProcessTools.createTestJavaProcessBuilder() we are calling  ---> Utils.addTestJavaOpts() which internally call prependTestJavaOpts();
> 
>>   public static String[] addTestJavaOpts(String... userArgs) {
>>         return prependTestJavaOpts(userArgs);
>>     }
> 
> -> Then again inside ProcessTools.createTestJavaProcessBuilder() method we are calling Utils.prependTestJavaOpts()
> 
>> public static ProcessBuilder createTestJavaProcessBuilder(String... command) {
>>         return createJavaProcessBuilder(Utils.prependTestJavaOpts(command));
>>     }
> 
> 
> Calling Utils.prependTestJavaOpts() twice leads to duplicate JVM flags (This method call-> getTestJavaOpts() the main reason for duplication and below is the implementation for the same. )
> 
>> public static String[] getTestJavaOpts() {
>>         List<String> opts = new ArrayList<String>();
>>         Collections.addAll(opts, safeSplitString(VM_OPTIONS));
>>         Collections.addAll(opts, safeSplitString(JAVA_OPTIONS));
>>         return opts.toArray(new String[0]);
>>     }
> 
> Contributed-by: @Korov 
> https://github.com/openjdk/jdk/pull/26404
> 
> https://bugs.openjdk.org/browse/JDK-8362658

test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineKeyLimit.java line 120:

> 118:                     System.getProperty("test.java.opts"));
> 119: 
> 120:             ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder("SSLEngineKeyLimit", "p", args[1], args[2]);

Looks good to me, but try not to overstep the 80 character line-width

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28428#discussion_r2546792171