RFR: 8362658: sun/security/ssl/SSLEngineImpl/* tests duplicate jvm flags [v3]

[Rajan Halade]

On Thu, 20 Nov 2025 16:56:53 GMT, Neha Joshi <duke at openjdk.org> wrote:

>> In this PR we have updated the code to remove the duplicate call and ensure JVM flags are added only once.
>> 
>> ### ISSUE :- 
>> In the test case --> ProcessTools.createTestJavaProcessBuilder(Utils.addTestJavaOpts("SSLEngineKeyLimit", "p", args[1], args[2]));
>>     
>> -> Before executing ProcessTools.createTestJavaProcessBuilder() we are calling  ---> Utils.addTestJavaOpts() which internally call prependTestJavaOpts();
>> 
>>>   public static String[] addTestJavaOpts(String... userArgs) {
>>>         return prependTestJavaOpts(userArgs);
>>>     }
>> 
>> -> Then again inside ProcessTools.createTestJavaProcessBuilder() method we are calling Utils.prependTestJavaOpts()
>> 
>>> public static ProcessBuilder createTestJavaProcessBuilder(String... command) {
>>>         return createJavaProcessBuilder(Utils.prependTestJavaOpts(command));
>>>     }
>> 
>> 
>> Calling Utils.prependTestJavaOpts() twice leads to duplicate JVM flags (This method call-> getTestJavaOpts() the main reason for duplication and below is the implementation for the same. )
>> 
>>> public static String[] getTestJavaOpts() {
>>>         List<String> opts = new ArrayList<String>();
>>>         Collections.addAll(opts, safeSplitString(VM_OPTIONS));
>>>         Collections.addAll(opts, safeSplitString(JAVA_OPTIONS));
>>>         return opts.toArray(new String[0]);
>>>     }
>> 
>> Contributed-by: @Korov 
>> https://github.com/openjdk/jdk/pull/26404
>> 
>> https://bugs.openjdk.org/browse/JDK-8362658
>
> Neha Joshi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8362658 : Reformat code to comply with 80-character line length limit

LGTM. Also include an update to remove tests from ProblemList at https://github.com/openjdk/jdk/blob/master/test/jdk/ProblemList-jvmti-stress-agent.txt#L31

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28428#issuecomment-3561156055