RFR: 8367326: Refactor PEM API tests requiring PEMRecord usage
Anthony Scarpino
ascarpino at openjdk.org
Thu Nov 27 01:44:46 UTC 2025
On Mon, 17 Nov 2025 16:56:03 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
> Changed to use PEM API:
> * test/jdk/sun/security/validator/PKIXValAndRevCheckTests.java
> * test/jdk/sun/security/rsa/pss/PSSKeyCompatibility.java
> * test/jdk/sun/security/pkcs11/rsa/TestKeyFactory.java
I understand the intent to use `PEM` here, but I think this is forcing the new API onto these tests rather than making it easier.
For `TestKeyFactory.java` I wouldn't make the change.
For the other two, I think it makes more sense to headers and footers to the base64 strings than using `PEM` to workaround it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28356#issuecomment-3583893195
More information about the security-dev
mailing list