RFR: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) [v10]

[Sean Mullan]

On Mon, 29 Sep 2025 20:53:12 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   another day another iteration
>
> src/java.base/share/classes/sun/security/pkcs12/MacData.java line 322:
> 
>> 320:      * ASN.1 encoding.
>> 321:      */
>> 322:     public byte[] getEncoded() throws NoSuchAlgorithmException, IOException {
> 
> Since you have moved the decoding of PBKDF2-Params into its own class, are you going to move the encoding there as well? Ideally, a `PBKDF2Parameters` object can be either created using a `DerValue` or its components (salt, ic, keyLen), and then it has a `getEncoded()` method.
> 
> Same with the new `PBMAC1Parameters` class.

Yes, I have the same comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2408245973