RFR: 8368984: Extra slashes in Cipher transformation leads to NSPE instead of NSAE [v2]
Valerie Peng
valeriep at openjdk.org
Tue Oct 7 01:05:50 UTC 2025
On Mon, 6 Oct 2025 19:48:48 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> There are quite a few values being updated here, that's why I didn't make it into a method initially. Let me think about it more...
>
> Both `sha512Idx` and `sha512SlashIdx` locally assigned, `SHA512TRUNCATED` is a constant, `transformation` is not mutated.
I did refactoring it using a record. If we apply the same method on mode as well, then the flow is simplified even though the mode should not contain truncated algorithms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27615#discussion_r2409062884
More information about the security-dev
mailing list