RFR: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) [v10]

[Mark Powers]

On Sat, 4 Oct 2025 21:22:10 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/pkcs12/MacData.java line 186:
>> 
>>> 184:             kdfHmac = macAlgorithm;
>>> 185:             Hmac = macAlgorithm;
>>> 186:         }
>> 
>> Did you consider adding another kdfHmac parameter to the method and passing in the correct values?
>
> This comment appears to apply to an earlier iteration. It is not easy to keep track of all these iterations. I believe the latest iteration fixes this.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2411823179