RFR: 8368677: acvp test should throw SkippedException when no ACVP-Server available

Mikhail Yankelevich myankelevich at openjdk.org
Wed Oct 8 15:19:50 UTC 2025


On Fri, 3 Oct 2025 15:14:07 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> test/jdk/sun/security/provider/acvp/Launcher.java line 124:
>> 
>>> 122:         } catch (IOException e) {
>>> 123:             if (e.getMessage().contains("Cannot find the artifact ACVP-Server")) {
>>> 124:                 throw new SkippedException("ACVP-Server not available, skip test.");
>> 
>> nit: 
>> Suggestion:
>> 
>>                 throw new SkippedException("ACVP-Server not available.");
>
> Hi @myankelev, can you just take a look at all our tests that call `ArtifactResolver.fetchOne` to see if it can directly throw a `SkippedException`? Thanks.

@wangweij `ArtifactResolver.fetchOne` is called in a couple of places but calls different artifacts. I think if it is changed to throw skipped exception itself it might end up not very descriptive. Also, it throws an IOException if it can't find a file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27491#discussion_r2414222141


More information about the security-dev mailing list