RFR: 8360564: Implement JEP 524: PEM Encodings of Cryptographic Objects (Second Preview) [v4]

Anthony Scarpino ascarpino at openjdk.org
Fri Oct 10 16:36:03 UTC 2025


On Wed, 1 Oct 2025 18:48:40 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> I cannot comment on the `@param provider` line. Shall we change "the Provider will be used" to "the Provider used"? This is consistent with `getKeyPair`.
>
> I also cannot comment on the `@throws NullPointerException` line. How about changing ". If" there to ", or if"? This appears in other methods as well.
> 
> Also, for other places when an NPE is thrown, sometimes you use "when the key or password is null", sometimes it's "if the key or password are null". Please use the same wording.

yes, I'll rework the NPE

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2417281599


More information about the security-dev mailing list