RFR: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) [v11]
Mark Powers
mpowers at openjdk.org
Sat Oct 11 02:39:18 UTC 2025
On Mon, 6 Oct 2025 19:01:04 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/util/PBKDF2Parameters.java line 89:
>>
>>> 87: private String prfAlgo = "HmacSHA1";
>>> 88:
>>> 89: public PBKDF2Parameters(DerValue keyDerivationFunc) throws IOException {
>>
>> Add some comments describing this ctor and its parameter.
>
> It's also a little unusual you are passing in the KDF algorithmId and not its parameters here.
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2422387054
More information about the security-dev
mailing list