RFR: 8369995: Implement extra logging and/or propagate errors in X509KeyManagerImpl and fix StringIndexOutOfBoundsException [v5]
Artur Barashev
abarashev at openjdk.org
Fri Oct 17 22:03:13 UTC 2025
On Fri, 17 Oct 2025 17:03:35 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> In [JDK-8309667](https://bugs.openjdk.org/browse/JDK-8309667), there were issues with debugging due to no logging or throwing of errors by X509KeyManagerImpl::getEntry. [Line](https://github.com/openjdk/jdk/blob/6a4c2676a6378f573bd58d1bc32b57765d756291/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java#L243-L245)
>>
>> Extra logging and error propagating should be implemented for the X509KeyManagerImpl.
>>
>> Additionally, dot checking logic has been changed, so no cases similar to `.A` will not trigger StringOutOfBounds exceptions.
>>
>> Thank you @djelinski for finding the issue and analysis.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>
> Artur's comments
src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 260:
> 258: // ignore and only log exception
> 259: if (SSLLogger.isOn && SSLLogger.isOn("keymanager")) {
> 260: SSLLogger.warning("Exception thrown while getting an alias " + alias + ": " + e);
Line length > 80
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2441360564
More information about the security-dev
mailing list