RFR: 8369995: Implement extra logging and/or propagate errors in X509KeyManagerImpl and fix StringIndexOutOfBoundsException [v6]

[Bradford Wetmore]

On Fri, 17 Oct 2025 22:39:49 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> In [JDK-8309667](https://bugs.openjdk.org/browse/JDK-8309667), there were issues with debugging due to no logging or throwing of errors by X509KeyManagerImpl::getEntry. [Line](https://github.com/openjdk/jdk/blob/6a4c2676a6378f573bd58d1bc32b57765d756291/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java#L243-L245)
>> 
>> Extra logging and error propagating should be implemented for the X509KeyManagerImpl.
>> 
>> Additionally, dot checking logic has been changed, so no cases similar to `.A` will not trigger StringOutOfBounds exceptions. 
>> 
>> Thank you @djelinski for finding the issue and analysis.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Artur's comments

A few initial comments.

src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 231:

> 229:             alias.length() - secondDot < 2) {
> 230: 
> 231:             if (SSLLogger.isOn && SSLLogger.isOn("keymanager")) {

`ssl,keymanager`   

We're in the process of cleaning these up.

src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 258:

> 256:                  IndexOutOfBoundsException e) {
> 257:             // ignore and only log exception
> 258:             if (SSLLogger.isOn && SSLLogger.isOn("keymanager")) {

`ssl,keymanager`

-------------

PR Review: https://git.openjdk.org/jdk/pull/27851#pullrequestreview-3357097856
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2445485209
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2445486206