RFR: 8369995: Implement extra logging and/or propagate errors in X509KeyManagerImpl and fix StringIndexOutOfBoundsException [v6]

[Mikhail Yankelevich]

On Mon, 20 Oct 2025 15:02:52 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Artur's comments
>
> test/jdk/sun/security/ssl/X509KeyManager/NullCases.java line 217:
> 
>> 215: 
>> 216:     @ParameterizedTest
>> 217:     @ValueSource(strings = {"..1", ".9.123456789"})
> 
> Please add tests with the `.` being the last character and with `..` in the middle of the string

Done in the next commit

> test/jdk/sun/security/ssl/X509KeyManager/X509KeyManagerNegativeTests.java line 59:
> 
>> 57:         // initialising exception throwing ks
>> 58:         // cleaned up after the tests are complete
>> 59:         final KeyManagerFactory exceptionThrowingKMF = KeyManagerFactory.getInstance("NewSunX509");
> 
> Line length here and throughout the rest of the file.

Done in the next commit

> test/jdk/sun/security/ssl/X509KeyManager/X509KeyManagerNegativeTests.java line 87:
> 
>> 85:     public static class MyCustomKSProvider extends java.security.Provider {
>> 86:         public MyCustomKSProvider() {
>> 87:             super("MyCustomKSProvider", 1.0, "My Custom KS Provider");
> 
> Deprecated constructor.

Done in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2445991824
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2445991265
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2445991481