RFR: 8369995: Implement extra logging and/or propagate errors in X509KeyManagerImpl and fix StringIndexOutOfBoundsException [v7]
Artur Barashev
abarashev at openjdk.org
Mon Oct 20 20:47:09 UTC 2025
On Mon, 20 Oct 2025 20:21:42 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> In [JDK-8309667](https://bugs.openjdk.org/browse/JDK-8309667), there were issues with debugging due to no logging or throwing of errors by X509KeyManagerImpl::getEntry. [Line](https://github.com/openjdk/jdk/blob/6a4c2676a6378f573bd58d1bc32b57765d756291/src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java#L243-L245)
>>
>> Extra logging and error propagating should be implemented for the X509KeyManagerImpl.
>>
>> Additionally, dot checking logic has been changed, so no cases similar to `.A` will not trigger StringOutOfBounds exceptions.
>>
>> Thank you @djelinski for finding the issue and analysis.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>
> comments
test/jdk/sun/security/ssl/X509KeyManager/NullCases.java line 223:
> 221:
> 222: @ParameterizedTest
> 223: @ValueSource(strings = {"1..",".1.", "..1", ".9.123456789"})
You still miss the test string with `..` in the middle.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2446079800
More information about the security-dev
mailing list