RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v4]

Mikhail Yankelevich myankelevich at openjdk.org
Thu Oct 23 11:41:06 UTC 2025


On Thu, 23 Oct 2025 11:29:34 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments
>
> test/jdk/sun/security/krb5/config/native/TestDynamicStore.java line 65:
> 
>> 63:         if (!"root".equals(System.getProperty("user.name"))) {
>> 64: 
>> 65:             JOptionPane.showMessageDialog(null, """
> 
> Is this dialog box necessary if the test will fail with the same message?

Yes, I believe so. The exception messages proved to be easy to miss for this test. Dialog box makes spotting the issue much easier imo

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26293#discussion_r2454828938


More information about the security-dev mailing list