RFR: 8366182: Some PKCS11Tests are being skipped when they shouldn't [v3]
Rajan Halade
rhalade at openjdk.org
Thu Oct 23 17:29:51 UTC 2025
On Wed, 17 Sep 2025 12:29:36 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> This PR updates PKCS11 tests to better handle NSS version numbers. The previous code treated the version numbers as double values and used comparison operators. The problem is that it incorrectly treats 3.111 as between 3.11 and 3.12. This update parses and compares the major and minor version numbers separately.
>
> Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into nss-skipped
> - refactored to encapsulate the version as a record instead of doing repeated string parsing
> - 8366182: Some PKCS11Tests are being skipped when they shouldn't
Marked as reviewed by rhalade (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/27095#pullrequestreview-3371448458
More information about the security-dev
mailing list