RFR: 8370368: Apply java.io.Serial annotations in java.security.jgss [v3]

Sergey Bylokhov serb at openjdk.org
Thu Oct 23 22:38:23 UTC 2025


On Thu, 23 Oct 2025 18:23:05 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace java.io.Serial annotations with @Serial
>
> src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java line 128:
> 
>> 126:     }
>> 127: 
>> 128:     @Serial
> 
> Can you also change `java.io.Serial` to `Serial` on the `readObject` method?

done

> `errorCode` should have `@Serial` too.

I think you may have confused it with the `@serial` tag in Javadoc. This annotation can be applied to these methods/fields.
  * private void writeObject(java.io.ObjectOutputStream stream) throws IOException
  * private void readObject(java.io.ObjectInputStream stream) throws IOException, ClassNotFoundException
  * private void readObjectNoData() throws ObjectStreamException 
   * ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
   * ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
   * private static final ObjectStreamField[] serialPersistentFields
   * private static final long serialVersionUID

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27925#discussion_r2457693746
PR Review Comment: https://git.openjdk.org/jdk/pull/27925#discussion_r2457684126


More information about the security-dev mailing list