RFR: 8360564: Implement JEP 524: PEM Encodings of Cryptographic Objects (Second Preview) [v8]

[Anthony Scarpino]

On Thu, 23 Oct 2025 20:36:09 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more doc updates and zeroing
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 134:
> 
>> 132:  * }
>> 133:  *
>> 134:  * @implNote This implementation decodes {@code RSA PRIVATE KEY} as {@code PRIVATE KEY},
> 
> Shall we say "decodes as" or "treat the same as"? You decode "RSA PRIVATE KEY" to `PrivateKey` and not "PRIVATE KEY".

I think the list is incorrect.  It should not have @code for the types, as I don't do that anywhere else.  Also, the "as" should be the class, not the other type.

> src/java.base/share/classes/java/security/PEMEncoder.java line 53:
> 
>> 51:  * <p> Encoding can be performed on cryptographic objects that
>> 52:  * implement {@link DEREncodable}. The {@link #encode(DEREncodable)}
>> 53:  * and {@link #encodeToString(DEREncodable)} methods encode a DEREncodable
> 
> `DEREncodable` should be in `{@code}`.

I think it's useful here to have a link because it is mentioned in the methods in the next sentence and below in the tables.  Similar to PEMDecoder has a link before the table.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2457386827
PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2457613713