RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v3]
Mikhail Yankelevich
myankelevich at openjdk.org
Tue Oct 28 15:14:48 UTC 2025
On Thu, 23 Oct 2025 16:49:06 GMT, Rajan Halade <rhalade at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> name changes for arrays
>
> test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 146:
>
>> 144: mgfHash,
>> 145: s);
>> 146: skipTest = true;
>
> I think skipTest logic in this test needs further updates. It starts with true as default value, should be false and only set skipTest to true when we encounter a test scenario that is not supported. I think there is also a case where skipTest value is overwritten at line 153 when called in a loop at line 95.
Done in the next commit. I have reworked it to be a list for easier debug in the future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2469957331
More information about the security-dev
mailing list