RFR: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) [v16]

Sean Mullan mullan at openjdk.org
Tue Oct 28 18:33:32 UTC 2025


On Mon, 27 Oct 2025 23:36:43 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> [JDK-8343232](https://bugs.openjdk.org/browse/JDK-8343232)
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   A4-A6 from RFC

src/java.base/share/classes/sun/security/pkcs12/PBMAC1Parameters.java line 118:

> 116:      * Encode PBMAC1 parameters from components.
> 117:      */
> 118:     static byte[] encode(byte[] salt, int iterationCount, int keyLength,

This is encoding more than the PBMAC1 parameters, it is also encoding the `DigestInfo` structure of the `MacData`. That should really be in the `MacData` class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2470643646


More information about the security-dev mailing list