RFR: 8366364: Address inconsistencies in SSLParameters object returned by SSLConfiguration#getSSLParameters() call [v3]
Artur Barashev
abarashev at openjdk.org
Tue Oct 28 19:57:10 UTC 2025
On Tue, 28 Oct 2025 18:52:44 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Log unavailable configured signature scheme
>
> src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 427:
>
>> 425: var ss = SignatureScheme.nameOf(name);
>> 426: if (ss == null && SSLLogger.isOn
>> 427: && SSLLogger.isOn("ssl,handshake")) {
>
> Do you need both `SSLLogger.isOn` and the isOn check for ssl,handshake? The latter check appears to only return true if it is both on and those flags have been set.
Good catch! That's how we do it throughout SSL code and I just followed that :) Coincidently, I recently was thinking why we need to do all this checks every time we log instead of specifying the log options as a parameter, and here I have just found `SSLLogger.logWarning` method that does just that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27961#discussion_r2470865475
More information about the security-dev
mailing list