RFR: 8367059: DTLS: loss of NewSessionTicket message results in handshake failure [v7]

Artur Barashev abarashev at openjdk.org
Wed Oct 29 14:47:34 UTC 2025


On Wed, 29 Oct 2025 03:39:52 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restore "createSSLEngine" access privileges to make existing tests pass
>
> src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java line 1631:
> 
>> 1629:                     && (!tc.sslConfig.isClientMode
>> 1630:                     || !tc.handshakeContext.statelessResumption
>> 1631:                     || hasCompleted(SSLHandshake.NEW_SESSION_TICKET.id));
> 
> Stylistically this is a bit weird putting the comment mid-stream into a complex logical comparison.  I get why you're doing it here, but I think it will be easier to read things if the comment goes above the return statement.

Sounds good, I'll make the change, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27677#discussion_r2473555499


More information about the security-dev mailing list