RFR: 8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 [v2]

[Sean Coffey]

On Wed, 29 Oct 2025 14:37:46 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Updated test to require `ssl,keymanager`, as it changed from `keymanager`.
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995

test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 26:

> 24: /**
> 25:  * @test
> 26:  * @bug 8350582 8340312

no bug ID should be inserted for test only fixes (AFAIK)

test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 61:

> 59:                 List.of("Produced ClientHello handshake message",
> 60:                         "supported_versions"));
> 61:         debugMessages.put("keymanager", List.of("choosing key:"));

I believe this is your root cause. Needs to change to "Choosing key:" since you changed case in 8369995

test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java line 111:

> 109:                 // all should print everything
> 110:                 Arguments.of(List.of("-Djavax.net.debug=all"),
> 111:                         List.of("handshake", "ssl,keymanager", "packet",

These string values are keys in to the `debugMessages` Map. Please revert. The upper case letter change is all that's required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28045#discussion_r2477150033
PR Review Comment: https://git.openjdk.org/jdk/pull/28045#discussion_r2477155327
PR Review Comment: https://git.openjdk.org/jdk/pull/28045#discussion_r2477170614