RFR: 8349732: Add support for JARs signed with ML-DSA [v4]
Matthew Donovan
mdonovan at openjdk.org
Thu Oct 30 18:28:45 UTC 2025
On Thu, 30 Oct 2025 17:54:33 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> test/lib/jdk/test/lib/security/DataFetcher.java line 78:
>>
>>> 76: } else {
>>> 77: try {
>>> 78: Path p = ArtifactResolver.resolve(klass).entrySet().stream()
>>
>> You don't need to introduce a new property. `ArtifactResolver.resolve()` already looks for a System property of the form `jdk.test.lib.artifacts.NAME` (where NAME = the name from the @Artifact class). If the property is specified, its value is returned from `resolve()` unmodified. You can get the URL from there.
>
> Yes, but that means I need to download the ZIP bundles somewhere. This new property allows me to work with local or remote repositories directly. Maybe not many people will use it.
The other option is to set `unpack=true` on the artifact class and then walk the directory returned from `ArtifactResolver.resolve()` to find the files you need. That would require people to have the files on their local machine but makes it easier to run the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2479102456
More information about the security-dev
mailing list