RFR: 8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995 [v3]

Bradford Wetmore wetmore at openjdk.org
Thu Oct 30 18:40:01 UTC 2025


On Thu, 30 Oct 2025 10:16:16 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Updated test to require `ssl,keymanager`, as it changed from `keymanager`.
>
> Mikhail Yankelevich has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - turbanoff's comment
>  - choosing -> Choosing

Took way to long to figure out that a capital letter changed in the SSL debug output, and that was causing the problem.   :)

Thank you for cleaning up the formatting.  Having lines <=80 sure helps with side/side comparisons like here in github.  

LGTM.

-------------

Marked as reviewed by wetmore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28045#pullrequestreview-3401109018


More information about the security-dev mailing list