RFR: 8365069: Refactor tests to use PEM API (Phase 1) [v2]

Anthony Scarpino ascarpino at openjdk.org
Thu Oct 30 21:26:06 UTC 2025


On Wed, 29 Oct 2025 20:54:56 GMT, Koushik Muthukrishnan Thirupattur <duke at openjdk.org> wrote:

>> The following tests have been identified as candidates for phase 1 of this change.
>> 2. test/jdk/javax/net/ssl/TLSCommon/TLSTest.java
>> 3. test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java
>> 4. test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilderWithMD5.java
>> 5. test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java
>> 9. test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java
>> 10. test/jdk/sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java
>> 11. test/jdk/sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java
>> 13. test/jdk/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java
>> 16. test/jdk/java/security/cert/CertPathBuilder/selfIssued/DisableRevocation.java
>> 17. test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevel.java
>> 18. test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevelRevoked.java
>> 20. test/jdk/java/security/KeyStore/PKCS12/WriteP12Test.java
>> 21. test/jdk/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java
>> 22. test/jdk/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithRID.java
>> 23. test/jdk/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithUnexpectedRID.java
>> 24. test/jdk/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithoutRID.java
>> 25. test/jdk/java/security/cert/CertPathValidator/trustAnchor/ValWithAnchorByName.java
>> 30. test/jdk/java/security/KeyStore/TestKeyStoreBasic.java
>
> Koushik Muthukrishnan Thirupattur has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8365069: Addressing review comments
>  - Merge branch 'master' into 8365069
>  - 8365069: Refactor tests to use PEM API (Phase 1)
>  - 8365069: Refactor tests to use PEM API (Phase 1)
>  - 8365069: Refactor tests to use PEM API (Phase 1)

Looks good

-------------

Marked as reviewed by ascarpino (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27267#pullrequestreview-3401718472


More information about the security-dev mailing list